svn generates long lists of empty diffs with --diff-cmd

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

svn generates long lists of empty diffs with --diff-cmd

Alexey Neyman-3
Hi,

I noticed that SVN generates a lot of spurious diffs when using a
--diff-cmd option that look like this:

Index: arch/alpha/boot/tools/objstrip.c
===================================================================
Index: arch/alpha/boot/Makefile
===================================================================

Is it possible to suppress such empty diffs? This makes the tools like
ReviewBoard (www.reviewboard.org) examine a lot of unchanged files and
slows them down considerably and unnecessary.

Regards,
Alexey.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: svn generates long lists of empty diffs with --diff-cmd

Bert Huijben-5


> -----Original Message-----
> From: Alexey Neyman [mailto:[hidden email]]
> Sent: donderdag 20 april 2017 02:59
> To: [hidden email]
> Subject: svn generates long lists of empty diffs with --diff-cmd
>
> Hi,
>
> I noticed that SVN generates a lot of spurious diffs when using a
> --diff-cmd option that look like this:
>
> Index: arch/alpha/boot/tools/objstrip.c
> ==========================================================
> =========
> Index: arch/alpha/boot/Makefile
> ==========================================================
> =========
>
> Is it possible to suppress such empty diffs? This makes the tools like
> ReviewBoard (www.reviewboard.org) examine a lot of unchanged files and
> slows them down considerably and unnecessary.

What argument do you pass to --diff-cmd ?

Is it possible that the files are actually different, but your diff command reports that they are not different (e.g. after normalizing whitespace). I think this header is printed on changed files, right before invoking the diff command.

        Bert

>
> Regards,
> Alexey.


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: svn generates long lists of empty diffs with --diff-cmd

Alexey Neyman-3
On 04/20/2017 06:52 AM, Bert Huijben wrote:

>> -----Original Message-----
>> From: Alexey Neyman [mailto:[hidden email]]
>> Sent: donderdag 20 april 2017 02:59
>> To: [hidden email]
>> Subject: svn generates long lists of empty diffs with --diff-cmd
>>
>> Hi,
>>
>> I noticed that SVN generates a lot of spurious diffs when using a
>> --diff-cmd option that look like this:
>>
>> Index: arch/alpha/boot/tools/objstrip.c
>> ==========================================================
>> =========
>> Index: arch/alpha/boot/Makefile
>> ==========================================================
>> =========
>>
>> Is it possible to suppress such empty diffs? This makes the tools like
>> ReviewBoard (www.reviewboard.org) examine a lot of unchanged files and
>> slows them down considerably and unnecessary.
> What argument do you pass to --diff-cmd ?
svn diff --diff-cmd=diff
> Is it possible that the files are actually different, but your diff command reports that they are not different (e.g. after normalizing whitespace). I think this header is printed on changed files, right before invoking the diff command.
No, plain 'svn diff' does not show any differences, not even properties.
For example:

[aneyman@rhel-build2 src]$ svn diff $URL/SETUP.bash SETUP.bash
[aneyman@rhel-build2 src]$ svn diff --diff-cmd=diff $URL/SETUP.bash
SETUP.bash
Index: SETUP.bash
===================================================================

Alexey.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: svn generates long lists of empty diffs with --diff-cmd

Alexey Neyman-3
On 04/20/2017 09:58 PM, Alexey Neyman wrote:

> On 04/20/2017 06:52 AM, Bert Huijben wrote:
>>> -----Original Message-----
>>> From: Alexey Neyman [mailto:[hidden email]]
>>> Sent: donderdag 20 april 2017 02:59
>>> To: [hidden email]
>>> Subject: svn generates long lists of empty diffs with --diff-cmd
>>>
>>> Hi,
>>>
>>> I noticed that SVN generates a lot of spurious diffs when using a
>>> --diff-cmd option that look like this:
>>>
>>> Index: arch/alpha/boot/tools/objstrip.c
>>> ==========================================================
>>> =========
>>> Index: arch/alpha/boot/Makefile
>>> ==========================================================
>>> =========
>>>
>>> Is it possible to suppress such empty diffs? This makes the tools like
>>> ReviewBoard (www.reviewboard.org) examine a lot of unchanged files and
>>> slows them down considerably and unnecessary.
>> What argument do you pass to --diff-cmd ?
> svn diff --diff-cmd=diff
>> Is it possible that the files are actually different, but your diff
>> command reports that they are not different (e.g. after normalizing
>> whitespace). I think this header is printed on changed files, right
>> before invoking the diff command.
> No, plain 'svn diff' does not show any differences, not even
> properties. For example:
>
> [aneyman@rhel-build2 src]$ svn diff $URL/SETUP.bash SETUP.bash
> [aneyman@rhel-build2 src]$ svn diff --diff-cmd=diff $URL/SETUP.bash
> SETUP.bash
> Index: SETUP.bash
> ===================================================================
Some more information:
- While the properties on the file itself are the same, the inherited
properties differ (at least, svn:mergeinfo on the parent directory).
- This behavior is observed on 1.10.0-dev, 1.9.x and 1.8.x. Subversion
1.7.x does not display these spurious  "Index:" lines.

Regards,
Alexey.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: svn generates long lists of empty diffs with --diff-cmd

Alexey Neyman-3
On 04/20/2017 10:44 PM, Alexey Neyman wrote:

> On 04/20/2017 09:58 PM, Alexey Neyman wrote:
>> On 04/20/2017 06:52 AM, Bert Huijben wrote:
>>>> -----Original Message-----
>>>> From: Alexey Neyman [mailto:[hidden email]]
>>>> Sent: donderdag 20 april 2017 02:59
>>>> To: [hidden email]
>>>> Subject: svn generates long lists of empty diffs with --diff-cmd
>>>>
>>>> Hi,
>>>>
>>>> I noticed that SVN generates a lot of spurious diffs when using a
>>>> --diff-cmd option that look like this:
>>>>
>>>> Index: arch/alpha/boot/tools/objstrip.c
>>>> ==========================================================
>>>> =========
>>>> Index: arch/alpha/boot/Makefile
>>>> ==========================================================
>>>> =========
>>>>
>>>> Is it possible to suppress such empty diffs? This makes the tools like
>>>> ReviewBoard (www.reviewboard.org) examine a lot of unchanged files and
>>>> slows them down considerably and unnecessary.
>>> What argument do you pass to --diff-cmd ?
>> svn diff --diff-cmd=diff
>>> Is it possible that the files are actually different, but your diff
>>> command reports that they are not different (e.g. after normalizing
>>> whitespace). I think this header is printed on changed files, right
>>> before invoking the diff command.
>> No, plain 'svn diff' does not show any differences, not even
>> properties. For example:
>>
>> [aneyman@rhel-build2 src]$ svn diff $URL/SETUP.bash SETUP.bash
>> [aneyman@rhel-build2 src]$ svn diff --diff-cmd=diff $URL/SETUP.bash
>> SETUP.bash
>> Index: SETUP.bash
>> ===================================================================
> Some more information:
> - While the properties on the file itself are the same, the inherited
> properties differ (at least, svn:mergeinfo on the parent directory).
> - This behavior is observed on 1.10.0-dev, 1.9.x and 1.8.x. Subversion
> 1.7.x does not display these spurious  "Index:" lines.
>
So, given the information above, can it be considered a bug/regression?

Regards,
Alexey.
> Regards,
> Alexey.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: svn generates long lists of empty diffs with --diff-cmd

Daniel Shahaf-2
Alexey Neyman wrote on Fri, May 05, 2017 at 08:50:07 -0700:

> On 04/20/2017 10:44 PM, Alexey Neyman wrote:
> >On 04/20/2017 09:58 PM, Alexey Neyman wrote:
> >>No, plain 'svn diff' does not show any differences, not even properties.
> >>For example:
> >>
> >>[aneyman@rhel-build2 src]$ svn diff $URL/SETUP.bash SETUP.bash
> >>[aneyman@rhel-build2 src]$ svn diff --diff-cmd=diff $URL/SETUP.bash
> >>SETUP.bash
> >>Index: SETUP.bash
> >>===================================================================
> >Some more information:
> >- While the properties on the file itself are the same, the inherited
> >properties differ (at least, svn:mergeinfo on the parent directory).
> >- This behavior is observed on 1.10.0-dev, 1.9.x and 1.8.x. Subversion
> >1.7.x does not display these spurious  "Index:" lines.
> >
> So, given the information above, can it be considered a bug/regression?

Sure.
Loading...