a little bug when checkout invalid url

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

a little bug when checkout invalid url

Shmuel Hanoch
Hi,

When I (accidently) tried to checkout some repository from a wrong url (with ":" instead of a "@"), the subversion process crushed on assertion. It's easy to reproduce on my machine, for example:

svn co svn+ssh://a:l       
svn: /build/subversion-8E3yhQ/subversion-1.9.3/subversion/libsvn_subr/dirent_uri.c:1339: svn_uri_basename: Assertion `svn_uri_is_canonical(uri, NULL)' failed.
zsh: abort (core dumped)  svn co svn+ssh://a:l

Although this is an "illegal" url, there probably should be some error handling instead of an assertion...

Thanks,

Shmuel Hanoch
Reply | Threaded
Open this post in threaded view
|

Re: a little bug when checkout invalid url

Johan Corveleyn-3
On Wed, Sep 27, 2017 at 5:22 PM, Shmuel Hanoch
<[hidden email]> wrote:

> Hi,
>
> When I (accidently) tried to checkout some repository from a wrong url (with
> ":" instead of a "@"), the subversion process crushed on assertion. It's
> easy to reproduce on my machine, for example:
>
> svn co svn+ssh://a:l
> svn:
> /build/subversion-8E3yhQ/subversion-1.9.3/subversion/libsvn_subr/dirent_uri.c:1339:
> svn_uri_basename: Assertion `svn_uri_is_canonical(uri, NULL)' failed.
> zsh: abort (core dumped)  svn co svn+ssh://a:l
>
> Although this is an "illegal" url, there probably should be some error
> handling instead of an assertion...
>
> Thanks,
>
> Shmuel Hanoch

Hi Shmuel,

Thanks for reporting this. But I think this has been fixed in trunk in
r1692262 [1]. The fix will be included in SVN 1.10 (if you want, you
might be able to verify this with the 1.10-alpha3 [2]).

I just tried here with a recent 1.10 build, and get a proper error message:

[[[
C:\>svn co svn+ssh://a:l
svn: E170000: Illegal repository URL 'svn+ssh://a:l'
]]]

[1] http://svn.apache.org/viewvc?view=revision&revision=1692262

[2] http://subversion.apache.org/#news-20170726

--
Johan