Windows build error introduced in revision 1850611

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Windows build error introduced in revision 1850611

Alexander Miloslavskiy
Hello,

I'm not subscribed, please CC me in answers.

For reference, build error text:
svndumpfilter.obj : error LNK2001: unresolved external symbol
svn_relpath__make_internal
[...\build\win32\vcnet-vcproj\svndumpfilter.vcxproj]

In revision 1850611 function was moved to new header
svn_dirent_uri_private.h which wasn't properly added to 'build.conf'.
This causes the generated 'libsvn_subr.def' file to not export the
function, which in turns causes 'unresolved external symbol'.

Please fix this by adding 'private\svn_dirent_uri_private.h' near line
370 in 'build.conf'.

Thanks!
Reply | Threaded
Open this post in threaded view
|

Re: Windows build error introduced in revision 1850611

Bert Huijben-5
  Hi,

I happened to find this issue myself today, short before your message was moderated through. I applied a fix to build.conf in r1851462, which should fix the problem. (It is currently being tested by our buildbot).

Thanks,
   Bert

On Wed, Jan 16, 2019 at 5:04 PM Alexander Miloslavskiy <[hidden email]> wrote:
Hello,

I'm not subscribed, please CC me in answers.

For reference, build error text:
svndumpfilter.obj : error LNK2001: unresolved external symbol
svn_relpath__make_internal
[...\build\win32\vcnet-vcproj\svndumpfilter.vcxproj]

In revision 1850611 function was moved to new header
svn_dirent_uri_private.h which wasn't properly added to 'build.conf'.
This causes the generated 'libsvn_subr.def' file to not export the
function, which in turns causes 'unresolved external symbol'.

Please fix this by adding 'private\svn_dirent_uri_private.h' near line
370 in 'build.conf'.

Thanks!