Win32 lock_tests 11 crashing

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Win32 lock_tests 11 crashing

D.J. Heap
This test is crashing due to a NULL hashtable pointer with this callstack:

  libapr.dll!find_entry
  libapr.dll!apr_hash_get
  svn.exe!store_locks_callback
  svn.exe!svn_ra_local__unlock
  svn.exe!svn_ra_unlock
  svn.exe!svn_client_unlock
  svn.exe!svn_cl__unlock
  svn.exe!main
  svn.exe!mainCRTStartup
  kernel32.dll!_BaseProcessStart@4

It appears to be related to the r14862 family of changes?

The test still passes after the crash, though.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Win32 lock_tests 11 crashing

Philip Martin
"D.J. Heap" <[hidden email]> writes:

> This test is crashing due to a NULL hashtable pointer with this callstack:
>
>   libapr.dll!find_entry
>   libapr.dll!apr_hash_get
>   svn.exe!store_locks_callback
>   svn.exe!svn_ra_local__unlock
>   svn.exe!svn_ra_unlock
>   svn.exe!svn_client_unlock
>   svn.exe!svn_cl__unlock
>   svn.exe!main
>   svn.exe!mainCRTStartup
>   kernel32.dll!_BaseProcessStart@4
>
> It appears to be related to the r14862 family of changes?

It's not just win32, 'svn unlock URL' is broken on all platforms.
When svn_client_unlock passes URLs to organize_lock_targets it gets
back a NULL urls_to_paths hash, as documented.  This gets stored in
the lock_baton passed to store_locks_callback which doesn't handle a
NULL hash.

> The test still passes after the crash, though.

The test should really be using run_and_verify_status to check what
happened, but in this case it would not help since the crash occurs
after the repository has unlocked.  Unlocking two URLs would detect
the problem, the crash would prevent the second URL getting unlocked.

Look at the next test, lock_unlock, it barely does any checking at
all!  It certainly doesn't verify that any locks get created or
released.

--
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]