Subversion 1.13.0-rc1 up for testing/signing

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

Subversion 1.13.0-rc1 up for testing/signing

Julian Foad-5
The 1.13.0-rc1 release artifacts are now available for testing/signing.
Please get the tarballs from
   https://dist.apache.org/repos/dist/dev/subversion
and add your signatures there.

Thanks!
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Julian Foad-5
Julian Foad wrote:
> The 1.13.0-rc1 release artifacts are now available for testing/signing.
> Please get the tarballs from
>    https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there.

Is anyone going to be able to help get the 1.13 release under way?

Please?

Is there anything I can do to make it easier?

- Julian


Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Nathan Hartman
On Mon, Sep 23, 2019 at 12:33 PM Julian Foad <[hidden email]> wrote:

>
> Julian Foad wrote:
> > The 1.13.0-rc1 release artifacts are now available for testing/signing.
> > Please get the tarballs from
> >    https://dist.apache.org/repos/dist/dev/subversion
> > and add your signatures there.
>
> Is anyone going to be able to help get the 1.13 release under way?
>
> Please?
>
> Is there anything I can do to make it easier?
>
> - Julian

Apologies for my silence lately.

I have been backlogged but started running tests today.
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Johan Corveleyn-3
In reply to this post by Julian Foad-5
On Tue, Sep 17, 2019 at 4:17 PM Julian Foad <[hidden email]> wrote:
>
> The 1.13.0-rc1 release artifacts are now available for testing/signing.
> Please get the tarballs from
>    https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there.
>
> Thanks!

(Sorry, Julian, it slipped my mind. Thanks for the reminder.)

Summary
-------
+1 to release

Platform
--------
Windows 7 SP1 (x64)
Microsoft Visual Studio 2017

Verified
--------
Signature and sha512 for subversion-1.13.0-rc1.zip.

Contents of subversion-1.13.0-rc1.zip are identical to tags/1.13.0-rc1,
and to branches/1.13.x@1867053 (except for expected differences in
svn_version.h and svnpubsub, svnwcsub and nominate.pl (symlinks vs. file
contents), and generated files).

Tested
------
[ Release build x86 ] x [ fsfs ] x [ file | svn | http ]
javahl
swig-python

Results
-------
All tests pass.

Dependencies
------------
Httpd 2.4.29 (pcre 8.41, apr 1.6.3, apr-iconv 1.22, apr-util 1.6.1, expat 2.2.5)
Apr 1.6.3
Apr-Util 1.6.1
OpenSSL 1.0.2n
Serf 1.3.9
SQLite 3.22.0.0
ZLib 1.2.11

Other tools
-----------
Perl 5.20 (Strawberry Perl)
Python 2.7.16
Swig 3.0.12
Oracle JDK 11.0.1
JUnit 4.12

Signature
---------

subversion-1.13.0-rc1.zip:
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAABCgAGBQJdiTYgAAoJELWc5tYBDIqt6mcP/0GbPvfijgW+eCSpqkR9NPXC
lMJ6h/+7Xq0/68tuRjyN9r7RSwEDkNMzhjY8+4T37XCFhZn5MpJ0rJgBmViGl0DM
Pj3uyVl8J1eHa4l1CbqyA4QJ9qnAr3HIxFXiNOIioblthR/s7fWgloJX+psbvERJ
SCGNdbN4iUHMXSZy4THBDyxLoR1OOwC7LPopzwbFd/lxVZsLAP5o8F/oeD69hhS1
HThSpeZS3Ik8r7pYxQx3E2+tuWBhT6CDSWthrnJ8tKNvgYhcK8d+2zrr9Vg+pL3w
ybO1ZoMhz8yRUqBXsjbqGuNvsoVGBgquj8MLuksz7qFCh5H0Tzh4F3dYAdkr9isz
m0AGJTcdD25f/LNpN4dbK21vTqayqbssJBoq5UbwdQu7lXL4r6P6SP2gAVOAZ1Qm
yukiO6imNYUwqeMXOX3HDhgZPkZ0qURZ0LXRpNA7QFVILSvuOe4Z71IZw9vBePDj
+L01EJQNL4lomcDpA+yhb6PmC+iNz4PSFhWHQD9e9gzIsSyO+rMRSYpsbAXdRRBl
n+lYZDYJURIzdsuoDZCf57bh2hzetBu+qIMU0Nf0xSgktg3y1zQRv6vpS4v+q2Os
W00JlxMe89qyFkxJYKhsOKBd8pgYS2qOEHOtXK9stuDtLn4l91H4uyjOBC8z/GpZ
c/NIJ5Dx3iovatWjVgnC
=+KT8
-----END PGP SIGNATURE-----


--
Johan
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Julian Foad-5
In reply to this post by Nathan Hartman
Nathan Hartman wrote:
> Apologies for my silence lately.
>
> I have been backlogged but started running tests today.

Thank you!

Johan Corveleyn wrote:
> (Sorry, Julian, it slipped my mind. Thanks for the reminder.)
> +1 to release

Thank you!

- Julian


Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Nathan Hartman
In reply to this post by Johan Corveleyn-3
On Tue, Sep 24, 2019 at 2:22 AM Johan Corveleyn <[hidden email]> wrote:
> Contents of subversion-1.13.0-rc1.zip are identical to tags/1.13.0-rc1,
> and to branches/1.13.x@1867053 (except for expected differences in
> svn_version.h and svnpubsub, svnwcsub and nominate.pl (symlinks vs. file
> contents), and generated files).

What do you use to compare the tarball contents to a working copy?
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Johan Corveleyn-3
On Fri, Sep 27, 2019 at 2:54 AM Nathan Hartman <[hidden email]> wrote:
>
> On Tue, Sep 24, 2019 at 2:22 AM Johan Corveleyn <[hidden email]> wrote:
> > Contents of subversion-1.13.0-rc1.zip are identical to tags/1.13.0-rc1,
> > and to branches/1.13.x@1867053 (except for expected differences in
> > svn_version.h and svnpubsub, svnwcsub and nominate.pl (symlinks vs. file
> > contents), and generated files).
>
> What do you use to compare the tarball contents to a working copy?

Ah, good question :-).

I use GNU diff, from within cygwin, after performing an 'svn export
https://.../tags/1.13.0-rc1' and 'svn export
https://.../branches/1.13.x@XXX' (where XXX is the revision I get from
executing 'svn log -v --stop-on-copy https://.../tags/1.13.0-rc1',
i.e. the revision from which the tag was copied from the branch). Then
I inspect that diff manually / visually.

Also: before running the export, I change my system timezone to UTC,
so "$Date$" keywords are expanded identically as in the tarball (those
always contain UTC dates it seems). There might be another way to
force "UTC timezone" during export for keyword expansion, but I don't
know how (on Windows). On Linux it's easy to do I guess (for instance
just setting TZ=XXX).

The diff is quite small, except some "$HeadUrl$" keyword expansions
(if the tarball was created from the tag, and I'm comparing to the
branch export), some files that are only part of one or the other. And
unfortunately on Windows symlinks are not supported, so I get "link
.../nominate.pl" on the exported side vs. <entire contents of
nominate.pl> on the other side. But I'm quite used to scrolling
through that one. On *nix that won't be a problem I'm sure.

I guess comparing to both the tag and the
branch@REV-from-which-the-tag-was-created is a bit redundant, since I
can trust SVN that they'll be identical modulo the modifications that
were part of the 'tag commit'.

This is a bit of manual work (I could script some parts of it I
suppose), but I'm used to doing that while the tests are running in
another window. So when the tests are finished, I'm mostly ready to
sign and commit.

--
Johan
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Branko Čibej
In reply to this post by Julian Foad-5
On 23.09.2019 18:33, Julian Foad wrote:

> Julian Foad wrote:
>> The 1.13.0-rc1 release artifacts are now available for testing/signing.
>> Please get the tarballs from
>>    https://dist.apache.org/repos/dist/dev/subversion
>> and add your signatures there.
>
> Is anyone going to be able to help get the 1.13 release under way?
>
> Please?
>
> Is there anything I can do to make it easier?


You can get me some extra time in the day. :)

I've started testing this release on macOS. Will be done soonish.

-- Brane
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Daniel Shahaf-2
In reply to this post by Johan Corveleyn-3
Johan Corveleyn wrote on Fri, 27 Sep 2019 07:41 +00:00:
> And unfortunately on Windows symlinks are not supported, so I get
> "link .../nominate.pl" on the exported side vs. <entire contents of
> nominate.pl> on the other side. But I'm quite used to scrolling
> through that one. On *nix that won't be a problem I'm sure.

Should we change tools/dist/dist.sh to delete nominate.pl before
rolling?  It's not like anyone building a tarball is going to need that, and
it'll remove a step from your release testing.

Cheers,

Daniel
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Julian Foad-6
Daniel Shahaf wrote:
> Johan Corveleyn wrote on Fri, 27 Sep 2019 07:41 +00:00:
>> And unfortunately on Windows symlinks are not supported, so I get
>> "link .../nominate.pl" on the exported side vs. <entire contents of
>> nominate.pl> on the other side. But I'm quite used to scrolling
>> through that one. On *nix that won't be a problem I'm sure.
>
> Should we change tools/dist/dist.sh to delete nominate.pl before
> rolling?  It's not like anyone building a tarball is going to need that, and
> it'll remove a step from your release testing.

There are three symlinks (svnpubsub, svnwcsub and nominate.pl).

Silently removing them doesn't seem like the ideal solution. IMO it
would create more confusion than it solves.

IMO, things that don't belong in a tarball don't belong in trunk. So,
maybe the whole of tools/dist should be moved up a level out of trunk.
But that doesn't help svnpubsub.

- Julian
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Nathan Hartman
In reply to this post by Johan Corveleyn-3
On Fri, Sep 27, 2019 at 3:41 AM Johan Corveleyn <[hidden email]> wrote:
>
> On Fri, Sep 27, 2019 at 2:54 AM Nathan Hartman <[hidden email]> wrote:
> > What do you use to compare the tarball contents to a working copy?
>
> Ah, good question :-).

Thank you for your very detailed answer, including the time zone.

Yes, it's much easier on *nix with a command like:

$ TZ=UTC bash -c 'svn export
https://svn.apache.org/repos/asf/subversion/tags/1.13.0-rc1'

Thanks again
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Nathan Hartman
On Tue, Sep 17, 2019 at 10:17 AM Julian Foad <[hidden email]> wrote:
>
> The 1.13.0-rc1 release artifacts are now available for testing/signing.
> Please get the tarballs from
>    https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there.

Please bear with me and all my n00b questions... :-)

The ASF committer keys list (https://people.apache.org/keys/committer/)
is showing my key as "key not found." Not really sure what to do about
that.

Also, some ASF help page (that I can't seem to locate now) said I need
to add my key to a KEYS file. Not sure where that is.

I've signed the bz2 and gz tarballs and am ready to commit my sigs;
should I wait until after fixing the above issue(s)?
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Julian Foad-5
Nathan Hartman wrote:
> On Tue, Sep 17, 2019 at 10:17 AM Julian Foad <[hidden email]> wrote:
>>
>> The 1.13.0-rc1 release artifacts are now available for testing/signing.
>> Please get the tarballs from
>>     https://dist.apache.org/repos/dist/dev/subversion
>> and add your signatures there.
>
> Please bear with me and all my n00b questions... :-)

No worries...

> The ASF committer keys list (https://people.apache.org/keys/committer/)
> is showing my key as "key not found." Not really sure what to do about
> that.

 From some things I just tried, it looks like it might be a temporary
failure of a keyserver.  When I tried

gpg --recv-keys --keyserver=hkp://keyserver.ubuntu.com:11371
583F00ADF981C39F

I got "keyserver receive failed: No data" about half the times I tried,
and success the other times. Another keyserver said "no data" every time.

I wouldn't worry about it, for now.  Carry on.

> Also, some ASF help page (that I can't seem to locate now) said I need
> to add my key to a KEYS file. Not sure where that is.

You should add them in https://id.apache.org ; you probably already
have.  AFAIK the KEYS file(s) are automatically generated from that,
nowadays.

> I've signed the bz2 and gz tarballs and am ready to commit my sigs;
> should I wait until after fixing the above issue(s)?

Don't wait. Validation against such a list is not necessary.

- Julian
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Daniel Shahaf-2
In reply to this post by Julian Foad-6
Julian Foad wrote on Fri, 27 Sep 2019 14:42 +00:00:
> IMO, things that don't belong in a tarball don't belong in trunk.

There must be exceptions to this, since autogen.sh belongs in trunk and
isn't expected to be run in tarball builds either.  The same goes for the
'extraclean' makefile target, and probably a few other things.

> So, maybe the whole of tools/dist should be moved up a level out of
> trunk. But that doesn't help svnpubsub.

Well, maybe, but then we'd have to fix all the bots to fetch backport.pl
from the right place, and fix backport_tests.py to import svntest
from the right place, and... In short, it'll be a small amount of churn.

Cheers,

Daniel
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Daniel Shahaf-2
In reply to this post by Nathan Hartman
Nathan Hartman wrote on Fri, 27 Sep 2019 14:46 +00:00:
> $ TZ=UTC bash -c 'svn export https://svn.apache.org/repos/asf/subversion/tags/1.13.0-rc1'

For future reference, «TZ=UTC svn export https://…» would work too.  The
environment variable setting syntax works for any external command ☺
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Daniel Shahaf-2
In reply to this post by Julian Foad-5
Julian Foad wrote on Fri, 27 Sep 2019 15:54 +00:00:
> > Also, some ASF help page (that I can't seem to locate now) said I need
> > to add my key to a KEYS file. Not sure where that is.
>
> You should add them in https://id.apache.org ; you probably already
> have.  AFAIK the KEYS file(s) are automatically generated from that,
> nowadays.

"KEYS file" refers to a file called "KEYS" in the distribution
directory, https://www.apache.org/dist/subversion/ which is a working
copy of https://svn.apache.org/repos/dist/release/subversion/.  Some
PMCs do it that way.  We don't use such a file; we rely on
https://people.apache.org/keys/ which contains auto-generated files.
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Nathan Hartman
In reply to this post by Julian Foad-5
On Tue, Sep 17, 2019 at 10:17 AM Julian Foad <[hidden email]> wrote:
>
> The 1.13.0-rc1 release artifacts are now available for testing/signing.
> Please get the tarballs from
>    https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there.

Signed! 1.13.0-rc1
+1 to release

Tested on *nix platforms:
* Debian GNU/Linux 10 "Buster" x64
* macOS 10.13.6 "High Sierra" x64

Verified contents, signatures, and checksums:
* subversion-1.13.0-rc1.tar.bz2:
  - Compared contents to tags/1.13.0-rc1; identical except generated files.
  - Verified signature
  - Verified SHA-512
* subversion-1.13.0-rc1.tar.gz:
  - All contents identical to those of subversion-1.13.0-rc1.tar.bz2.
  - Verified signature
  - Verified SHA-512

Test details, Debian GNU/Linux 10 "Buster" x64:
* Tests:
  - fsfs, file | svn | http: 2528 PASSED, 98 SKIPPED, 89 XFAILED
  - swig-python passed
  - swig-perl passed
* Dependencies:
  - APR 1.6.5
  - APRUTIL 1.6.1
  - Serf 1.3.9
  - Swig 3.0.12
  - Python 2.7.16
  - Perl 5.28.1

Test details, macOS 10.13.6 "High Sierra" x64:
* Tests:
  - fsfs, file | svn: 2526 PASSED, 98 SKIPPED, 91 XFAILED
* Dependencies:
  - APR 1.6.3
  - APRUTIL 1.6.1

Signatures added to https://dist.apache.org/repos/dist/dev/subversion
in r36099.

Signature, subversion-1.13.0-rc1.tar.bz2:
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEP45GfLM2bjAT4RINWD8ArfmBw58FAl2OHcoACgkQWD8ArfmB
w594VRAAn/tGgpsMQW24ra4t2yx8IdbdivED90Zybl8RXqXlMdwZsH2bfNrtloZw
BbnVKJZde5rT+sGh3bwdoMlKzfvhyds7V+lM9UPzeJg7T3GnYmqr1qgbwPsD9PMy
JjMz27WmoA/QP1H+kYW0Flo2f3HGZf3e9eawwHNeh7qk6GBwS2MCxm8PXLpchiLZ
BvxMVNDtYbJGA9ktEG1lCxEX3wdDJ4wbpqFIKOC2o2L/U27oV0vOKYK5VVmuJL56
wYACqtbRR6oGRHAmBWHhpPs3rcVXnzzHKNSs2pf6Zh4egyL/yVckoyTi1MHoyAh/
R5w1YQAbij/w+U5b91fFAei+i3oPJSP2PhO41X2i5p3MTJptv8FwIJQhHnWWfo48
lUYG87krk4uZCszJQoK4d/UlLlupiIh+ydPpSC4j/7jnXB5tpgr9gcfP6uqdVaXo
c07wFUxOtxrE9hWDgVHYqDaPWx8zQwZ8dVbL32oMLS3kz87pJe19Sny6q4TIXG9M
XhetvXI1uQbCU4nSm+H1GInF7IEcUhE75OwhRLByg2MAxHyuKfi0CEqned5zZxTZ
Nz3IxVcUr/wuAxkpPUJ5MsUsaIqNWDfkC23RWwxwvGX9KPDz19chbPEpZmKcna76
IxJUIF3PCPRJ/Wk5NFJo6HnwF6DVqoWRFUseSZyK2LLjLCxqn84=
=b/yD
-----END PGP SIGNATURE-----

Signature, subversion-1.13.0-rc1.tar.gz:
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEP45GfLM2bjAT4RINWD8ArfmBw58FAl2OHfsACgkQWD8ArfmB
w5+NuxAAmjtupcsM5Hrf/oRiFmijy+7YcFmPCWWwn5RJ8vQpuc9nNQE/2NxV+tYr
kpbTlfbvxGgJ2bgChmLKKR0EoEQtp4hSkz+1BM/P4q5qW33FR1+qf3c9grHJwAx6
TU8SwKsGkBk3bw7ZF3Ho5qTU3akehio1dOnjHr/UAX3PeQ1j8Wa7/N0lQ6um67cE
plWXH3iLSL72jOXvIVFXN7Kkp6LkWv0W2/gqwItheJAYgsJ04QnYYGWXH5K5gIGV
XtrUwKn7YWypo5dmarpmOfz9Kp9HdE8gp8P5xiFphD5G3bfrMLnCq3UEtbHL4nLu
fDPbeyVbt/Xe6ieTuvNmmGUGeR6BxQsYYUOIKaQkuOEQjbBGxTGYtg2yxpFVE+KI
K8Wv0Gfcnfg8QCpd/E1zIxBiePOpSoy3vyYXoVIwH4ozm2ELcfzvSa8wQK05+TnE
lmjsqrU/fKiIV5gZcVSrdRsrvUFC0j/ULrsqtWnCp1/otb95TI58tpjWm2gAT4Yt
uSSpUuM3zEY+V3H97AyMuz2CEYhwECthUVf6e7zwoMTMXb3bdwv5lRR6bzW1qnJl
HNCpupaGZuihh0ZmRyHuPoYk9P08qVR7XGhH7GBxqAd5H9uU+P7SrH7MEyY1JhrS
HkwpBcQPZi+nRwb0DZWo5+mFi+40lobF4PMfK8v9n9m9fFNOqfY=
=lZAJ
-----END PGP SIGNATURE-----
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Johan Corveleyn-3
In reply to this post by Julian Foad-6
On Fri, Sep 27, 2019 at 4:42 PM Julian Foad <[hidden email]> wrote:

>
> Daniel Shahaf wrote:
> > Johan Corveleyn wrote on Fri, 27 Sep 2019 07:41 +00:00:
> >> And unfortunately on Windows symlinks are not supported, so I get
> >> "link .../nominate.pl" on the exported side vs. <entire contents of
> >> nominate.pl> on the other side. But I'm quite used to scrolling
> >> through that one. On *nix that won't be a problem I'm sure.
> >
> > Should we change tools/dist/dist.sh to delete nominate.pl before
> > rolling?  It's not like anyone building a tarball is going to need that, and
> > it'll remove a step from your release testing.
>
> There are three symlinks (svnpubsub, svnwcsub and nominate.pl).
>
> Silently removing them doesn't seem like the ideal solution. IMO it
> would create more confusion than it solves.
>
> IMO, things that don't belong in a tarball don't belong in trunk. So,
> maybe the whole of tools/dist should be moved up a level out of trunk.
> But that doesn't help svnpubsub.

No problem. Probably best to leave things as they are now. It's not a
big deal at the moment.
Though if anyone would like to tackle symlink support on Windows ...
that'd be good :-).

--
Johan
Reply | Threaded
Open this post in threaded view
|

Re: Subversion 1.13.0-rc1 up for testing/signing

Branko Čibej
In reply to this post by Julian Foad-5
Summary:

    +1 to release (Unix)

Verified:

  - Tarball contents and signatures
  - check ((fsfs, bdb) × (local, svnserve, dav))
  - check-all-javahl
  - check-swig-py
  - check-swig-rb
  - check-swig-pl

Known issues:

  - 'make check-swig-py' requires 'make install install-swig-py'.
  - 'make check-swig-rb' requires 'make install install-swig-rb'.

Platform

    macOS Mojave 10.14.6

    Standard dependencies:
      Apple clang version 11.0.0 (clang-1100.0.33.8)
      ruby 2.3.7p456 (2018-03-28 revision 63024)
      Python 2.7.10
      Cyrus SASL 2.1.26

    Dependencies from Homebrew:
      APR 1.7.0
      APR-Util 1.6.1
      httpd 2.4.41
      SQLite 3.29.0
      Serf 1.3.9
      OpenSSL 1.0.2t
      zlib 1.2.11
      LZ4 1.9.2
      utf8proc 2.4.0
      BDB 18.1.32
      Perl 5.30.0

    Other dependencies:
      Java 11 2018-09-25
      JUnit 4.11

GPG signatures NOT committed to the
dist/dev/subversion repository, due to
the release having been published first ...