Should 'svn patch' say nothing when it does nothing?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Should 'svn patch' say nothing when it does nothing?

Daniel Shahaf-2
I tried to commit r1820518 by extracting the patch from the mail to a
file and using 'svn patch':

% svn patch /tmp/patch
% svn status
%

Now, in this situation, should 'svn patch' have said something to the
effect of "svn: No patch found in input"?  I'm aware of "Nothing done,
nothing said", but in this situation the user specifically asked for
something to be done and that something was not done, so shouldn't the
user be advised of that?

Cheers,

Daniel

P.S. The reason 'svn patch' did nothing is because the patch had been
     whitespace munged (tab became space, trailing spaces got elided).
     I just fell back to my OS's patch(1) and it ate the patch unsalted
     (this idiom doesn't translate, does it?).