Re: svn commit: r1847181 - /subversion/trunk/subversion/tests/cmdline/copy_tests.py

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1847181 - /subversion/trunk/subversion/tests/cmdline/copy_tests.py

Branko Čibej
On 22.11.2018 16:56, [hidden email] wrote:
> Author: julianfoad
> Date: Thu Nov 22 15:56:22 2018
> New Revision: 1847181
>
> URL: http://svn.apache.org/viewvc?rev=1847181&view=rev
> Log:
> Add a test for issue SVN-4792: Foreign repo copy of file adding mergeinfo.

[...]

> -  expected_output = svntest.verify.UnorderedOutput([
> -    '--- Copying from foreign repository URL \'%s\':\n' % E_url_resolved,
> -    'A         %s\n' % sbox.ospath('E'),
> -    'A         %s\n' % sbox.ospath('E/beta'),
> -    'A         %s\n' % sbox.ospath('E/alpha'),
> -  ])


This is broken. You replaced the UnorderedOutput comparator with a
simple array of lines, causing test failures like this:

https://ci.apache.org/builders/svn-x64-macosx-bdb/builds/3968/steps/Test%20ra_local%2Bbdb/logs/faillog

-- Brane

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1847181 - /subversion/trunk/subversion/tests/cmdline/copy_tests.py

Julian Foad-5
Branko Čibej wrote:
> This is broken. You replaced the UnorderedOutput comparator with a
> simple array of lines, causing test failures like this:
>
> https://ci.apache.org/builders/svn-x64-macosx-bdb/builds/3968/steps/Test%20ra_local%2Bbdb/logs/faillog

Thanks. Fixed in 1847264. Backport nominations updated.

--
- Julian