Re: svn commit: r1816069 - /subversion/branches/1.8.x-issue4707/subversion/svnrdump/dump_editor.c

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1816069 - /subversion/branches/1.8.x-issue4707/subversion/svnrdump/dump_editor.c

Evgeny Kotkov
Julian Foad <[hidden email]> writes:

> -                                ": %lu\n",
> -                                (unsigned long)info->size));
> +                                ": %" APR_SIZE_T_FMT "\n",
> +                                info->size));

I think that using APR_SIZE_T_FMT would still lead to the same issue with
large file sizes in the 32-bit environment (where size_t is also 32 bit).

Perhaps, the code should be using APR_OFF_T_FMT as the format specifier?

(The apr_file_info_t.size value is an apr_off_t)


Regards,
Evgeny Kotkov
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1816069 - /subversion/branches/1.8.x-issue4707/subversion/svnrdump/dump_editor.c

Julian Foad-5
Evgeny Kotkov wrote:

> Julian Foad <[hidden email]> writes:
>
>> -                                ": %lu\n",
>> -                                (unsigned long)info->size));
>> +                                ": %" APR_SIZE_T_FMT "\n",
>> +                                info->size));
>
> I think that using APR_SIZE_T_FMT would still lead to the same issue with
> large file sizes in the 32-bit environment (where size_t is also 32 bit).
>
> Perhaps, the code should be using APR_OFF_T_FMT as the format specifier?
>
> (The apr_file_info_t.size value is an apr_off_t)

Thank you! I will fix it.

- Julian

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1816069 - /subversion/branches/1.8.x-issue4707/subversion/svnrdump/dump_editor.c

Julian Foad-5
Julian Foad wrote:
> Evgeny Kotkov wrote:
>> I think that using APR_SIZE_T_FMT would still lead to the same issue with
>> large file sizes in the 32-bit environment (where size_t is also 32 bit).
>>
>> Perhaps, the code should be using APR_OFF_T_FMT as the format specifier?
>>
>> (The apr_file_info_t.size value is an apr_off_t)
>
> Thank you! I will fix it.

Fixed in r1816111 on '1.8.x-issue4707' branch. 'STATUS' nomination updated.

- Julian