Re: svn commit: r1814018 - /subversion/site/staging/quick-start.html

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1814018 - /subversion/site/staging/quick-start.html

Daniel Shahaf-2
[hidden email] wrote on Wed, 01 Nov 2017 22:44 +0000:
> +++ subversion/site/staging/quick-start.html Wed Nov  1 22:44:22 2017
> @@ -80,8 +80,8 @@ we recommend you do a Web search for <tt
> -The repository acts as a single source of truth and – as a central
> -storage – it contains the complete history of changes of the versioned
> +The repository acts as a single source of truth and - as a central
> +storage - it contains the complete history of changes of the versioned

Pavel, that's not the correct fix.  The original text used a U+2013 EN
DASH, which you changed to an ASCII hyphen.  The correct fix would be to
use U+2014 EM DASH.  (The escape sequence is "&mdash;", although I for
one wouldn't object to using a literal "—".)

Thanks for spotting this!

Daniel
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1814018 - /subversion/site/staging/quick-start.html

Pavel Lyalyakin
Hello,

On Thu, Nov 2, 2017 at 2:05 AM, Daniel Shahaf <[hidden email]> wrote:

>
> [hidden email] wrote on Wed, 01 Nov 2017 22:44 +0000:
> > +++ subversion/site/staging/quick-start.html Wed Nov  1 22:44:22 2017
> > @@ -80,8 +80,8 @@ we recommend you do a Web search for <tt
> > -The repository acts as a single source of truth and – as a central
> > -storage – it contains the complete history of changes of the versioned
> > +The repository acts as a single source of truth and - as a central
> > +storage - it contains the complete history of changes of the versioned
>
> Pavel, that's not the correct fix.  The original text used a U+2013 EN
> DASH, which you changed to an ASCII hyphen.  The correct fix would be to
> use U+2014 EM DASH.  (The escape sequence is "&mdash;", although I for
> one wouldn't object to using a literal "—".)
>
> Thanks for spotting this!
>
> Daniel

Fixed in r1814193.

Changed to "&mdash;" as we use it on other pages.

--
With best regards,
Pavel Lyalyakin
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1814018 - /subversion/site/staging/quick-start.html

Daniel Shahaf-2
Pavel Lyalyakin wrote on Fri, 03 Nov 2017 17:56 +0300:
> Fixed in r1814193.
>
> Changed to "&mdash;" as we use it on other pages.

Thanks, Pavel.  Looks good to me (with the followup in r1814194).

Cheers,

Daniel
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1814018 - /subversion/site/staging/quick-start.html

Daniel Shahaf-2
Daniel Shahaf wrote on Fri, 03 Nov 2017 20:13 +0000:
> Pavel Lyalyakin wrote on Fri, 03 Nov 2017 17:56 +0300:
> > Fixed in r1814193.
> >
> > Changed to "&mdash;" as we use it on other pages.
>
> Thanks, Pavel.  Looks good to me (with the followup in r1814194).

To be clear, that was meant as a "+1 to merge r1814018, r1814193,
r1814194 to publish/".

You made some other commits to quick-start that haven't been merged to
publish/ yet, haven't you?  What are they waiting for?

> Cheers,
>
> Daniel
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1814018 - /subversion/site/staging/quick-start.html

Pavel Lyalyakin
Hello Daniel,

On Tue, Nov 14, 2017 at 4:41 PM, Daniel Shahaf <[hidden email]> wrote:

> Daniel Shahaf wrote on Fri, 03 Nov 2017 20:13 +0000:
>> Pavel Lyalyakin wrote on Fri, 03 Nov 2017 17:56 +0300:
>> > Fixed in r1814193.
>> >
>> > Changed to "&mdash;" as we use it on other pages.
>>
>> Thanks, Pavel.  Looks good to me (with the followup in r1814194).
>
> To be clear, that was meant as a "+1 to merge r1814018, r1814193,
> r1814194 to publish/".
>
> You made some other commits to quick-start that haven't been merged to
> publish/ yet, haven't you?  What are they waiting for?

You are right. There is a +1 from you and it has been much longer than 72 hours
so it seems that there is a lazy consensus. :)

I've promoted the changes made to /staging/quickstart.html in r1815233.

>> Cheers,
>>
>> Daniel

--
With best regards,
Pavel Lyalyakin
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1814018 - /subversion/site/staging/quick-start.html

Johan Corveleyn-3
On Tue, Nov 14, 2017 at 6:02 PM, Pavel Lyalyakin <[hidden email]> wrote:

> Hello Daniel,
>
> On Tue, Nov 14, 2017 at 4:41 PM, Daniel Shahaf <[hidden email]> wrote:
>> Daniel Shahaf wrote on Fri, 03 Nov 2017 20:13 +0000:
>>> Pavel Lyalyakin wrote on Fri, 03 Nov 2017 17:56 +0300:
>>> > Fixed in r1814193.
>>> >
>>> > Changed to "&mdash;" as we use it on other pages.
>>>
>>> Thanks, Pavel.  Looks good to me (with the followup in r1814194).
>>
>> To be clear, that was meant as a "+1 to merge r1814018, r1814193,
>> r1814194 to publish/".
>>
>> You made some other commits to quick-start that haven't been merged to
>> publish/ yet, haven't you?  What are they waiting for?
>
> You are right. There is a +1 from you and it has been much longer than 72 hours
> so it seems that there is a lazy consensus. :)
>
> I've promoted the changes made to /staging/quickstart.html in r1815233.

Well done, Pavel :-). And sorry I didn't give you any more feedback on
your changes on staging (I had intended to take a look and +1 them as
well, but had to disengage a little bit for some weeks ... it's been
too busy lately).

Anyway, keep up the good work, and don't hesitate to merge to the live
site if noone here responds after 72 hours.

--
Johan