Re: svn commit: r1785734 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: svn commit: r1785734 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

Daniel Shahaf-2
[hidden email] wrote on Mon, Mar 06, 2017 at 19:05:45 -0000:
> +static svn_error_t *
> +test_rep_sharing_strict_content_check(const svn_test_opts_t *opts,
> +                                      apr_pool_t *pool)
> +{
> +  /* Bail (with success) on known-untestable scenarios */
> +  if (strcmp(opts->fs_type, SVN_FS_TYPE_BDB) == 0)
> +    return svn_error_create(SVN_ERR_TEST_SKIPPED, NULL,
> +                            "this will not test BDB repositories");

Minor point: the log message^W^W skip message should answer "Why", not
"What".  Suggestion:

    "bdb does not have a rep-cache"
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: svn commit: r1785734 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

Stefan Fuhrmann
On 06.03.2017 21:53, Daniel Shahaf wrote:

> [hidden email] wrote on Mon, Mar 06, 2017 at 19:05:45 -0000:
>> +static svn_error_t *
>> +test_rep_sharing_strict_content_check(const svn_test_opts_t *opts,
>> +                                      apr_pool_t *pool)
>> +{
>> +  /* Bail (with success) on known-untestable scenarios */
>> +  if (strcmp(opts->fs_type, SVN_FS_TYPE_BDB) == 0)
>> +    return svn_error_create(SVN_ERR_TEST_SKIPPED, NULL,
>> +                            "this will not test BDB repositories");
> Minor point: the log message^W^W skip message should answer "Why", not
> "What".  Suggestion:
>
>      "bdb does not have a rep-cache"
>
I simply copied that from previous tests ...
Changed in r1786447.

-- Stefan^2.
Loading...