Re: svn commit: r14968 - branches/server-l10n/subversion/libsvn_ra_dav

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r14968 - branches/server-l10n/subversion/libsvn_ra_dav

Jani Averbach
On 2005-06-03 16:01-0500, [hidden email] wrote:

> Author: dlr
> Date: Fri Jun  3 16:01:29 2005
> New Revision: 14968
>
> Modified:
>    branches/server-l10n/subversion/libsvn_ra_dav/util.c
>
> Log:
> * subversion/libsvn_ra_dav/util.c
>   (parsed_request): LC_MESSAGES isn't available on Windows, but we
>    could use LC_ALL when calling setlocale() there.  However, Windows
>    and some Linux may return friendly aliases for the language and
>    country codes, which do not appear to be permitted per section 3.10
>    of RFC 2616.  ifdef'd out sending of Accept-Language on Windows
>    (general solution in the works).  Duplicate the return value of
>    setlocale(), since we'll be manipulating that memory (and it could
>    be read-only).

As from lurker's point of view, should this explanation be located on
the code instead of the commit message?

BR, Jani

--
Jani Averbach

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r14968 - branches/server-l10n/subversion/libsvn_ra_dav

Daniel Rall
On Fri, 2005-06-03 at 16:31 -0600, Jani Averbach wrote:

> On 2005-06-03 16:01-0500, [hidden email] wrote:
> > Author: dlr
> > Date: Fri Jun  3 16:01:29 2005
> > New Revision: 14968
> >
> > Modified:
> >    branches/server-l10n/subversion/libsvn_ra_dav/util.c
> >
> > Log:
> > * subversion/libsvn_ra_dav/util.c
> >   (parsed_request): LC_MESSAGES isn't available on Windows, but we
> >    could use LC_ALL when calling setlocale() there.  However, Windows
> >    and some Linux may return friendly aliases for the language and
> >    country codes, which do not appear to be permitted per section 3.10
> >    of RFC 2616.  ifdef'd out sending of Accept-Language on Windows
> >    (general solution in the works).  Duplicate the return value of
> >    setlocale(), since we'll be manipulating that memory (and it could
> >    be read-only).
>
> As from lurker's point of view, should this explanation be located on
> the code instead of the commit message?

Yah, thanks for the comment, Jani.  Fortunately, I ended up replacing
this code with a much simpler scheme after discussing things with people
on IRC (I think lunblad came up with the new scheme).  See the changes
to this file in r14971 if you're interested.

- Dan



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]