Re: svn_client_log2 doesn't take a peg revision

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn_client_log2 doesn't take a peg revision

Greg Hudson
On Sun, 2005-04-24 at 03:48, SteveKing wrote:
> While playing around with the new svn_client_log2() API and its 'limit'
> param I noticed that this API doesn't take a peg revision. I think it
> should.

+1, although I won't be developing a patch for it myself.

(I think some developers have considered peg-rev processing for "svn
log" unnecessary since svn log naturally already has history-following
logic.  But that logic only applies to displaying history once we've
found a starting point; peg-rev processing should still apply to finding
the starting point.)


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn_client_log2 doesn't take a peg revision

C. Michael Pilato
Greg Hudson <[hidden email]> writes:

> On Sun, 2005-04-24 at 03:48, SteveKing wrote:
> > While playing around with the new svn_client_log2() API and its 'limit'
> > param I noticed that this API doesn't take a peg revision. I think it
> > should.
>
> +1, although I won't be developing a patch for it myself.

+1, same disclaimer. :-)

> (I think some developers have considered peg-rev processing for "svn
> log" unnecessary since svn log naturally already has history-following
> logic.  But that logic only applies to displaying history once we've
> found a starting point; peg-rev processing should still apply to finding
> the starting point.)

Or, it could have just been an oversight.  Regardless, yeah,
history-following or not, all subcommands which operate on paths
should be peg-aware.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]