RE: svn commit: r1803158 - in /subversion/trunk/subversion/libsvn_subr: compress.c compress_lz4.c compress_zlib.c encode.c

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: svn commit: r1803158 - in /subversion/trunk/subversion/libsvn_subr: compress.c compress_lz4.c compress_zlib.c encode.c

Bert Huijben-5


> -----Original Message-----
> From: [hidden email] [mailto:[hidden email]]
> Sent: donderdag 27 juli 2017 12:00
> To: [hidden email]
> Subject: svn commit: r1803158 - in
> /subversion/trunk/subversion/libsvn_subr: compress.c compress_lz4.c
> compress_zlib.c encode.c
>
> Author: kotkov
> Date: Thu Jul 27 09:59:47 2017
> New Revision: 1803158
>
> URL: http://svn.apache.org/viewvc?rev=1803158&view=rev
> Log:
> Split libsvn_subr/compress.c into three files.
>
> This file contained routines for zlib and LZ4 compression and for general
> data encoding, such as svn__encode_uint().  It would be better to maintain
> all of these three groups separately.
>
> * subversion/libsvn_subr/compress.c
>   (svn__encode_uint, svn__encode_int, svn__decode_uint,
> svn__decode_int):
>    Move to encode.c.
>   (svn_zlib__compiled_version, svn_zlib__runtime_version,
>    svnCompressBound, MIN_COMPRESS_SIZE, zlib_encode, zlib_decode,
>    svn__compress_zlib, svn__decompress_zlib): Move to compress_zlib.c.
>   (svn__compress_lz4, svn__decompress_lz4): Move to compress_lz4.c.
>
> * subversion/libsvn_subr/encode.c,
>   subversion/libsvn_subr/compress_zlib.c,
>   subversion/libsvn_subr/compress_lz4.c: New files.
>
> Added:
>     subversion/trunk/subversion/libsvn_subr/compress_lz4.c   (with props)
>     subversion/trunk/subversion/libsvn_subr/compress_zlib.c   (with props)
>     subversion/trunk/subversion/libsvn_subr/encode.c   (with props)
> Removed:
>     subversion/trunk/subversion/libsvn_subr/compress.c

Would have been nice if all these files were based of a copy of compress.c, to allow following history in a bit easier way.

        Bert

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Heuristic detection of copies [was: svn commit: r1803158 ...]

Julian Foad-5
Bert Huijben wrote:
>> Added:
>>     subversion/trunk/subversion/libsvn_subr/compress_lz4.c
>>     subversion/trunk/subversion/libsvn_subr/compress_zlib.c
>>     subversion/trunk/subversion/libsvn_subr/encode.c
>> Removed:
>>     subversion/trunk/subversion/libsvn_subr/compress.c
>
> Would have been nice if all these files were based of a copy of compress.c, to allow following history in a bit easier way.

This kind of scenario is making me think heuristic detection of copies
(and moves) is quite a good idea after all :-)

- Julian

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: svn commit: r1803158 - in /subversion/trunk/subversion/libsvn_subr: compress.c compress_lz4.c compress_zlib.c encode.c

Evgeny Kotkov
In reply to this post by Bert Huijben-5
Bert Huijben <[hidden email]> writes:

> Would have been nice if all these files were based of a copy of compress.c,
> to allow following history in a bit easier way.

Indeed.  I reverted the original change in r1803192 and re-applied it
in r1803194, while making the new files copied from compress.c.


Thanks,
Evgeny Kotkov
Loading...