[Patch] Blame test for unkown revision

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patch] Blame test for unkown revision

Alexander Thomas
[[[
 Patch to add blame test for unkown revision

* subversion/clients/cmdline/blame-cmd.c
  (svn_cl__blame): Removed line for fixing multiple targets on
  blame, even if one or more of the target is either a directory
  or a un-revisioned file

* subversion/clients/cmdline/main.c
  (svn_cl__cmd_table[]): re-arranged options --incremental, --xml
  as in list and log

* subversion/tests/clients/cmdline/blame_tests.py
  (blame_on_unknown_revision): New test for blame output on
   unknown revision
  (test_list): added blame_on_unknown_revision

* tools/client-side/bash_completion
  (_svn): Add "--incremental" and "--xml" options to "blame" command.
]]]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

log.txt (668 bytes) Download Attachment
blame.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Blame test for unkown revision

kfogel
<[hidden email]> writes:

> [[[
>  Patch to add blame test for unkown revision
>
> * subversion/clients/cmdline/blame-cmd.c
>   (svn_cl__blame): Removed line for fixing multiple targets on
>   blame, even if one or more of the target is either a directory
>   or a un-revisioned file
>
> * subversion/clients/cmdline/main.c
>   (svn_cl__cmd_table[]): re-arranged options --incremental, --xml
>   as in list and log
>
> * subversion/tests/clients/cmdline/blame_tests.py
>   (blame_on_unknown_revision): New test for blame output on
>    unknown revision
>   (test_list): added blame_on_unknown_revision
>
> * tools/client-side/bash_completion
>   (_svn): Add "--incremental" and "--xml" options to "blame" command.
> ]]]

I can't tell from this log message what problem is being solved here.
Can you describe it?


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Blame test for unkown revision

Alexander Thomas
In reply to this post by Alexander Thomas
Sorry for not notifying about multiple fixes in this patch, I left it
because all are very minor fixes. So Here we go..
Patch has 4 changes/fix
On Mon, 2005-05-16 at 11:10 -0500, [hidden email] wrote:
> <[hidden email]> writes:
> > [[[
> >  Patch to add blame test for unkown revision
> >
> > * subversion/clients/cmdline/blame-cmd.c
> >   (svn_cl__blame): Removed line for fixing multiple targets on
> >   blame, even if one or more of the target is either a directory
> >   or a un-revisioned file
   When we give multiple targets on svn blame and if one of the target
is either a directory or a un-revisioned file, we will get a incomplete
xml output and blame terminates prematurely. U can get details about the
discussion at http://svn.haxx.se/dev/archive-2005-05/0604.shtml

> >
> > * subversion/clients/cmdline/main.c
> >   (svn_cl__cmd_table[]): re-arranged options --incremental, --xml
> >   as in list and log
> >
   A simple rearrangement of options to standardize svn help on blame
with list and log

> > * subversion/tests/clients/cmdline/blame_tests.py
> >   (blame_on_unknown_revision): New test for blame output on
> >    unknown revision
> >   (test_list): added blame_on_unknown_revision

http://svn.haxx.se/dev/archive-2005-05/0547.shtml


> > * tools/client-side/bash_completion
> >   (_svn): Add "--incremental" and "--xml" options to "blame" command.
added new blame option --incremental and --xml in bash auto-completion
(programmable completion and extended pattern matching) script

> > ]]]
>

Hope this will do :)


Thanks
-Alexander Thomas (AT)



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Blame test for unkown revision

Michael W Thelen
[hidden email] wrote:
> Sorry for not notifying about multiple fixes in this patch, I left it
> because all are very minor fixes. So Here we go..
> Patch has 4 changes/fix

Is anyone able to review this patch in the next few days?  If not, I
will file an issue for it.

--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Blame test for unkown revision

Michael W Thelen
Michael W Thelen wrote:
> [hidden email] wrote:
>>Sorry for not notifying about multiple fixes in this patch, I left it
>>because all are very minor fixes. So Here we go..
>>Patch has 4 changes/fix
>
> Is anyone able to review this patch in the next few days?  If not, I
> will file an issue for it.

I've filed this patch as issue #2326:
http://subversion.tigris.org/issues/show_bug.cgi?id=2326

--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]