[PATCH] gpg-agent storage - add support for /run based sockets V4

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] gpg-agent storage - add support for /run based sockets V4

Lukas Jirkovsky
Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent socket.

Now it also unescapes the path according to gpgconf man page which
says the path is percent-escaped.

I'm not sure about using svn_cstring_split on svn_stringbuf_t data
member though, but I could not find a similar functionality for string
buffer.

[[[
Find gpg-agent socket using gpgconf if possible.
This allows detection of socket with Gnupg >= 2.1.13
which changed the default socket path to /run/user/UID/gnupg

* subversion/libsvn_subr/gpg_agent.c
    (find_gpgconf_agent_socket): new function to find
    gpg-agent socket using gpgconf
    (find_running_gpg_agent): use find_gpgconf_agent_socket
    to detect socket when possible.
]]]

gpg_agent_socket_paths_v4.diff (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] gpg-agent storage - add support for /run based sockets V4

Lukas Jirkovsky
On 4 May 2017 at 23:54, Lukas Jirkovsky <[hidden email]> wrote:
> Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent socket.

I just noticed I accidentally generated the patch from inside the
"subversion" subdirectory. I hope that's not a problem.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] gpg-agent storage - add support for /run based sockets V4

James McCoy-3
On Fri, May 05, 2017 at 09:41:03AM +0200, Lukas Jirkovsky wrote:
> On 4 May 2017 at 23:54, Lukas Jirkovsky <[hidden email]> wrote:
> > Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent socket.
>
> I just noticed I accidentally generated the patch from inside the
> "subversion" subdirectory. I hope that's not a problem.

No, it's not. :) It looks good to me, other than a few typos.  I'll
test it out soon.

Cheers,
--
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] gpg-agent storage - add support for /run based sockets V4

James McCoy-3
On Fri, May 05, 2017 at 11:29:09PM -0400, James McCoy wrote:
> On Fri, May 05, 2017 at 09:41:03AM +0200, Lukas Jirkovsky wrote:
> > On 4 May 2017 at 23:54, Lukas Jirkovsky <[hidden email]> wrote:
> > > Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent socket.
> >
> > I just noticed I accidentally generated the patch from inside the
> > "subversion" subdirectory. I hope that's not a problem.
>
> No, it's not. :) It looks good to me, other than a few typos.  I'll
> test it out soon.

Thanks for the patch!  Committed in r1794166.

Cheers,
--
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB
Loading...