[PATCH] Add LZ4 version info to svn --version -v

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Add LZ4 version info to svn --version -v

Ivan Zhakov-2
Log message:
[[[
Add LZ4 library verison info to svn --version -v.

* subversion/libsvn_subr/sysinfo.c
  (): Include lz4/lz4internal.h or lz4.h depending on SVN_INTERNAL_LZ4.
  (svn_sysinfo__linked_libs): Add LZ4 library version info.
]]]

--
Ivan Zhakov

lz4-version-info-v1.patch.txt (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add LZ4 version info to svn --version -v

Ivan Zhakov-2
On 11 August 2017 at 23:28, Ivan Zhakov <[hidden email]> wrote:
> Log message:
> [[[
> Add LZ4 library verison info to svn --version -v.
>
> * subversion/libsvn_subr/sysinfo.c
>   (): Include lz4/lz4internal.h or lz4.h depending on SVN_INTERNAL_LZ4.
>   (svn_sysinfo__linked_libs): Add LZ4 library version info.
> ]]]
>
V2 version of the patch:
- display 'static' for statically linked LZ4
- do not use LZ4_VERSION_STRING and LZ4_versionString() API, because
they are not available in older version of LZ4 library.



--
Ivan Zhakov

lz4-version-info-v2.patch.txt (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add LZ4 version info to svn --version -v

Johan Corveleyn-3
On Sun, Aug 13, 2017 at 6:53 AM, Ivan Zhakov <[hidden email]> wrote:

> On 11 August 2017 at 23:28, Ivan Zhakov <[hidden email]> wrote:
>> Log message:
>> [[[
>> Add LZ4 library verison info to svn --version -v.
>>
>> * subversion/libsvn_subr/sysinfo.c
>>   (): Include lz4/lz4internal.h or lz4.h depending on SVN_INTERNAL_LZ4.
>>   (svn_sysinfo__linked_libs): Add LZ4 library version info.
>> ]]]
>>
> V2 version of the patch:
> - display 'static' for statically linked LZ4
> - do not use LZ4_VERSION_STRING and LZ4_versionString() API, because
> they are not available in older version of LZ4 library.
>
>
>
> --
> Ivan Zhakov

Hi Ivan!

Looks good to me. Go ahead and commit I'd say :-).

Thanks,
--
Johan