[GitHub] subversion pull request #5: pytest tests for svn-viewspec

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] subversion pull request #5: pytest tests for svn-viewspec

pono
GitHub user paul-hammant opened a pull request:

    https://github.com/apache/subversion/pull/5

    pytest tests for svn-viewspec

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-hammant/subversion trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/subversion/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
   
----
commit 99831e957f51ebc45ad4f52d9fdfec02523b6d0f
Author: Paul Hammant <[hidden email]>
Date:   2017-09-14T10:20:12Z

    tests for svn-viewspec

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] subversion pull request #5: pytest tests for svn-viewspec

pono
Github user pono closed the pull request at:

    https://github.com/apache/subversion/pull/5


---
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] subversion pull request #5: pytest tests for svn-viewspec

Julian Foad-5
> Github user pono closed the pull request at:
>
>      https://github.com/apache/subversion/pull/5

For the record, this was closed by ASF infra at my request because I had
committed (a modified version of) the patch in r1827200:

------------------------------------------------------------------------
r1827200 | julianfoad | 2018-03-19 13:43:41 +0000 (Mon, 19 Mar 2018) |
12 lines
Changed paths:
    M /subversion/trunk/tools/client-side/svn-viewspec.py
    A /subversion/trunk/tools/client-side/svnviewspec_test.py

Viewspec: Add regression tests for 'svn-viewspec.py'.

Patch by: Paul Hammant <paul[_AT_]hammant.org>
modified by me

* tools/client-side/svn-viewspec.py
   Prepare for testability: allow passing in a mock 'os.system' object, and
   make main() externally callable.

* tools/client-side/svnviewspec_test.py
   New file, for use with Python 'pytest'.

------------------------------------------------------------------------

The stupid non-integration with GitHub shows GH users their standard
Pull Request UX to begin with, but supports virtually no follow-up after
that and is in fact an almost read-only mirror, so the PR flow is not
far off being a black hole.  Apparently I had no way to comment there on
GH about what had happened to this PR, nor to mark it as closed myself.
All I could do was request ASF's infra department to close it as they
had the admin rights.

- Julian