[GitHub] subversion pull request #18: Add HTML lang="en"

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] subversion pull request #18: Add HTML lang="en"

pono
GitHub user skotfred opened a pull request:

    https://github.com/apache/subversion/pull/18

    Add HTML lang="en"

    Primarily an accessibility concern for screen reader software.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skotfred/subversion trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/subversion/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18
   
----

----


---
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] subversion pull request #18: Add HTML lang="en"

Branko Čibej
On Wed, 23 Jan 2019, 05:56 skotfred <[hidden email] wrote:
GitHub user skotfred opened a pull request:

    https://github.com/apache/subversion/pull/18

    Add HTML lang="en"

    Primarily an accessibility concern for screen reader software.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skotfred/subversion trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/subversion/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18



Before anyone starts saying that GitHub PR's are the wrong medium for sending patches: the changes themselves are mostly irrelevant, and those that add the "lang" attribute where it's not allowed by the DTD are actually wrong.

-- Brane
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] subversion pull request #18: Add HTML lang="en"

Julian Foad-5
Branko Čibej wrote:
> On Wed, 23 Jan 2019, 05:56 skotfred <[hidden email] wrote:
>>      https://github.com/apache/subversion/pull/18
>>  
>>      Add HTML lang="en"
>>  
>>      Primarily an accessibility concern for screen reader software.
>
> Before anyone starts saying that GitHub PR's are the wrong medium for sending patches:

We should discuss that in another thread. Bearing in mind that "we" (the ASF) set up that medium, what matters on this thread is that a user kindly offered us a patch.

> the changes themselves are mostly irrelevant, and those that add the "lang" attribute where it's not allowed by the DTD are actually wrong.

Could you respond to the user, on github, or would you prefer someone else to?

- Julian
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] subversion pull request #18: Add HTML lang="en"

Branko Čibej
On 24.01.2019 11:55, Julian Foad wrote:

> Branko Čibej wrote:
>> On Wed, 23 Jan 2019, 05:56 skotfred <[hidden email] wrote:
>>>      https://github.com/apache/subversion/pull/18
>>>  
>>>      Add HTML lang="en"
>>>  
>>>      Primarily an accessibility concern for screen reader software.
>> Before anyone starts saying that GitHub PR's are the wrong medium for sending patches:
> We should discuss that in another thread. Bearing in mind that "we" (the ASF) set up that medium, what matters on this thread is that a user kindly offered us a patch.
>
>> the changes themselves are mostly irrelevant, and those that add the "lang" attribute where it's not allowed by the DTD are actually wrong.
> Could you respond to the user, on github, or would you prefer someone else to?

We should put something there that points to this one of these pages,
and leave it at that:

    https://subversion.apache.org/contributing.html
    https://subversion.apache.org/reporting-issues.html

We have never encouraged throwing patches at us without discussion and I
would be against starting now. If I were to respond there, it would be
to reject the pull request and post one of those links as the reason.
However some people might not agree with such a blunt approach, so I'm
not going to do anything.

I only responded to this thread to point out that the patch is clearly
wrong, or at least most of it is. Which isn't surprising, given that it
was created without any discussion and apparently with very little
attempt at understanding.

-- Brane

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] subversion pull request #18: Add HTML lang="en"

Julian Foad-5
Branko Čibej wrote:
> We should put something there that points to this one of these pages,
> and leave it at that:
>
>     https://subversion.apache.org/contributing.html
>     https://subversion.apache.org/reporting-issues.html

I'll move this part of the discussion to a new thread, as I requested.

--
- Julian
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] subversion pull request #18: Add HTML lang="en"

Julian Foad-5
And I put a polite "please come and talk to us" response on the PR. I haven't closed it yet; we'll see how the contributor responds.

--
- Julian
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] subversion pull request #18: Add HTML lang="en"

Branko Čibej
On 24.01.2019 12:38, Julian Foad wrote:
> And I put a polite "please come and talk to us" response on the PR. I haven't closed it yet; we'll see how the contributor responds.

Thanks.

-- Brane

Reply | Threaded
Open this post in threaded view
|

[GitHub] subversion pull request #18: Add HTML lang="en"

pono
In reply to this post by pono
Github user skotfred closed the pull request at:

    https://github.com/apache/subversion/pull/18


---