Fwd: [jira] [Commented] (SVN-4700) Null update breaks last-changed-rev

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Fwd: [jira] [Commented] (SVN-4700) Null update breaks last-changed-rev

Daniel Shahaf-2
Moving discussion to dev@.

Daniel Shahaf (äñ§€¥£¢) (JIRA) wrote on Mon, 30 Oct 2017 16:24 +0000:

> > Null update breaks last-changed-rev
> > -----------------------------------
> >
> >                 Key: SVN-4700
> >                 URL: https://issues.apache.org/jira/browse/SVN-4700
> >             Project: Subversion
> >          Issue Type: Bug
> >            Reporter: Daniel Shahaf (äñ§€¥£¢)
> >
> > See https://svn.apache.org/r1813771 for details, in the form of a regression test.
>
>

tl;dr: A bug in last-changed-revision was reported on users@, a regression
test and a fix have been committed, but we should audit nearby code for a
potential similar problem:

> http://svn.apache.org/r1813794 fixes the file content case.  We should also audit the other callers of svn_fs_contents_different and svn_fs_props_different and see whether they should use svn_fs_contents_changed and svn_fs_props_changed (respectively), particularly the calls elsewhere in reporter.c.

Daniel