Bugreport: invalid xml file produced by: svn log --xml --verbose --use-merge-history --search "msg1"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Bugreport: invalid xml file produced by: svn log --xml --verbose --use-merge-history --search "msg1"

Martin Obermeir
Hi all,

I'd like to report a bug: "svn log --xml" produces an invalid xml when
the "--use-merge-history" option is combined with "--search"

Example: svn log --xml --verbose --use-merge-history --search "msg1".

The xml contains two closing "</logentry>" tags, but only one opening
<logentry> tag.

Details see below.

I could not find this bug in the issue tracker/mailing list. The bug can
be easily reproduced with the script attached to this email, it is also
available here:
https://gist.github.com/anonymous/91aa228d6c22bff7ec2cbba2aecb2cd3

Environment:

Your operating system
-  Kubuntu 17.10 (Linux 4.13.0-17-generic #20-Ubuntu SMP Mon Nov 6
10:04:08 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux)
The release and/or revision of Subversion
   - svn, version 1.9.7 (r1800392)
       compiled Aug 17 2017, 10:20:03 on x86_64-pc-linux-gnu
   - also trunk 1.11.0-dev confirmed by "danielsh" on IRC:
http://sprunge.us/YYbL
The compiler and configuration options you built Subversion with
-  (from apt)
Any private modifications you made to your Subversion
-  (none)
The version of Berkeley DB you're running Subversion with, if any
-  (none)
Anything else that could possibly be relevant. Err on the side of too
much information, rather than too little.
- Expected output:
     xml with just one "</logentry>" line
- Actual output (see last lines):
     <?xml version="1.0" encoding="UTF-8"?>
     <log>
     <logentry
     reverse-merge="false"
     revision="3">
     <author>xyz</author>
     <date>2017-12-11T10:14:38.084171Z</date>
     <paths>
     <path
     kind="file"
     action="M"
     prop-mods="false"
     text-mods="true">/trunk/iota</path>
     </paths>
     <msg>msg1</msg>
     </logentry>
     </logentry>
     </log>

May I enter this bug to the issue tracker?

Best regards
Martin

repro-svn-log-xml-search.sh (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bugreport: invalid xml file produced by: svn log --xml --verbose --use-merge-history --search "msg1"

Paul Hammant-3
I would say yes, but I am an end user too. The good news is that it feels like a bug that would be easy to solve.
Reply | Threaded
Open this post in threaded view
|

Re: Bugreport: invalid xml file produced by: svn log --xml --verbose --use-merge-history --search "msg1"

Johan Corveleyn-3
On Wed, Dec 13, 2017 at 8:50 AM, Paul Hammant <[hidden email]> wrote:
> I would say yes, but I am an end user too. The good news is that it feels
> like a bug that would be easy to solve.

+1

--
Johan
Reply | Threaded
Open this post in threaded view
|

Re: Bugreport: invalid xml file produced by: svn log --xml --verbose --use-merge-history --search "msg1"

Martin Obermeir
Reply | Threaded
Open this post in threaded view
|

Re: Bugreport: invalid xml file produced by: svn log --xml --verbose --use-merge-history --search "msg1"

Martin Obermeir
In reply to this post by Johan Corveleyn-3
Hi all,

I entered this bug to the issue tracker last year:
https://issues.apache.org/jira/browse/SVN-4711

Should I also post it to the development list ([hidden email]
<mailto:[hidden email]>)?

Thanks


On 13.12.2017 10:08, Johan Corveleyn wrote:
> +1
>

Reply | Threaded
Open this post in threaded view
|

Re: Bugreport: invalid xml file produced by: svn log --xml --verbose --use-merge-history --search "msg1"

Johan Corveleyn-3
On Tue, Feb 20, 2018 at 3:17 PM, Martin Obermeir
<[hidden email]> wrote:
> Hi all,
>
> I entered this bug to the issue tracker last year:
> https://issues.apache.org/jira/browse/SVN-4711
>
> Should I also post it to the development list ([hidden email]
> <mailto:[hidden email]>)?

Hi Martin,

It was good that you tracked this down, and filed an issue (with
reproduction script), but unfortunately this doesn't guarantee that
someone will pick this up and fix it. After all, Apache Subversion is
an open source project largely driven by volunteers these days. So, it
depends ...

Asking again on dev@ doesn't really help either (several devs already
follow this list), unless you have some proposal on how to fix it. For
example, drilling down into the source code, pointing to the place in
the code where it goes wrong, or even proposing a patch, ... those are
certainly useful inputs for a post to dev@.

Or as they say ... patches welcome ;-).

--
Johan